docs(buttons): add selection buttons composition variants#1561
docs(buttons): add selection buttons composition variants#1561dauriamarco wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds documentation for different composition variants of selection buttons and refactors the corresponding examples. The changes in the examples correctly simplify the HTML structure by removing unnecessary <span> elements. The new documentation is helpful, but the code example for the 'Input wrapped inside label' variant contains an error: the radio buttons are missing the name attribute, which is necessary for them to function correctly as a group. I've added a suggestion to fix this.
|
Documentation. Coverage Reports: |
71e4a72 to
4e856ba
Compare
|
|
| <label> | ||
| <input type="checkbox" class="btn-check" aria-label="One pane" siTooltip="One pane" checked /> | ||
| <si-icon class="btn btn-icon icon" icon="element-layout-pane-1" /> | ||
| </label> | ||
|
|
There was a problem hiding this comment.
I am still unsure, what we should recommend to projects here.
I guess wrapping it in a label is the way nicer approach, and as written in the other PR, maybe maybe moving the btn btn-icon classes to the label
2 participants
Resolves #941